Skip to content

don't write out strings from find_locale_strings during tests #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2018
Merged

don't write out strings from find_locale_strings during tests #2232

merged 1 commit into from
Jan 3, 2018

Conversation

alexcjohnson
Copy link
Collaborator

but we still want to run the rest of the script as it ensures we wrapped all strings

@etpinard as discussed in #2227 (comment) so we're not modifying dist/ when we don't intend to. build will still produce a new translation_keys.txt file.

@alexcjohnson
don't write out strings from find_locale_strings during tests
13eb140 
but we still want to run the rest of the script as it ensures we wrapped all strings
@etpinard
Copy link
Contributor

etpinard commented Jan 3, 2018

Nicely done 💃

@alexcjohnson alexcjohnson merged commit 5e16992 into master Jan 3, 2018
@alexcjohnson alexcjohnson deleted the no-strings-on-test branch January 3, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcjohnson @etpinard